Address CR comments

optimizely · Mar 20, 2017 · a3df65f · a3df65f
1 parent 8953172
commit a3df65f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/Optimizely/Utils/EventTagUtils.php b/src/Optimizely/Utils/EventTagUtils.php
@@ -27,8 +27,8 @@ class EventTagUtils
     /**
      * Grab the revenue value from the event tags. "revenue" is a reserved keyword.
      *
-     * @param $eventTags array representing metadata associated with the event.
-     * @return number revenue value as an integer number or null if revenue can't be retrieved from the event tags
+     * @param $eventTags array Representing metadata associated with the event.
+     * @return integer Revenue value as an integer number or null if revenue can't be retrieved from the event tags
      */
     public static function getRevenueValue($eventTags) {
         if (!$eventTags) {

diff --git a/src/Optimizely/Utils/Validator.php b/src/Optimizely/Utils/Validator.php
@@ -26,7 +26,7 @@ class Validator
     /**
      * @param $datafile string JSON string representing the project.
      *
-     * @return boolean representing whether schema is valid or not.
+     * @return boolean Representing whether schema is valid or not.
      */
     public static function validateJsonSchema($datafile)
     {
@@ -41,7 +41,7 @@ public static function validateJsonSchema($datafile)
     /**
      * @param $attributes mixed Attributes of the user.
      *
-     * @return boolean representing whether attributes are valid or not.
+     * @return boolean Representing whether attributes are valid or not.
      */
     public static function areAttributesValid($attributes)
     {
@@ -51,7 +51,7 @@ public static function areAttributesValid($attributes)
     /**
      * @param $eventTags mixed Event tags to be validated.
      *
-     * @return boolean representing whether event tags are valid or not.
+     * @return boolean Representing whether event tags are valid or not.
      */
     public static function areEventTagsValid($eventTags)
     {

diff --git a/tests/UtilsTests/ValidatorTest.php b/tests/UtilsTests/ValidatorTest.php
@@ -72,7 +72,7 @@ public function testAreAttributesValidInvalidAttributes()
         $this->assertFalse(Validator::areAttributesValid([0, 1, 2, 42, 'abc' => 'def']));
     }
 
-    public function testAreEventTagsValidValidAttributes()
+    public function testAreEventTagsValidValidEventTags()
     {
         // Empty attributes
         $this->assertTrue(Validator::areEventTagsValid([]));
@@ -85,7 +85,7 @@ public function testAreEventTagsValidValidAttributes()
         ]));
     }
 
-    public function testAreEventTagsValidInvalidAttributes()
+    public function testAreEventTagsValidInvalidEventTags()
     {
         // String as attributes
         $this->assertFalse(Validator::areEventTagsValid('Invalid string attributes.'));