Skip to content

Commit

Permalink
Changes to address phrasing and comment to explain flake8 ignore W504
Browse files Browse the repository at this point in the history
  • Loading branch information
The-inside-man committed Jul 9, 2021
1 parent f0c1733 commit 617cc4d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .flake8
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
[flake8]
# E722 - do not use bare 'except'
# W504 - Either W503 (Line break after Operand) or W503 (
# Line break before operand needs to be ignored for line lengths
# greater than max-line-length. Best practice shows W504
ignore = E722, W504
exclude = optimizely/lib/pymmh3.py,*virtualenv*
max-line-length = 120
4 changes: 2 additions & 2 deletions optimizely/project_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ def is_feature_experiment(self, experiment_id):
return experiment_id in self.experiment_feature_map

def get_variation_from_id_by_experiment_id(self, experiment_id, variation_id):
""" Gets experiment id and variation id
""" Gets variation from variation id and specific experiment id
Returns:
The variation for the experiment id and variation id
Expand All @@ -584,7 +584,7 @@ def get_variation_from_id_by_experiment_id(self, experiment_id, variation_id):
return {}

def get_variation_from_key_by_experiment_id(self, experiment_id, variation_key):
""" Gets experiment id and variation key
""" Gets variation from variation key and specific experiment id
Returns:
The variation for the experiment id and variation key
Expand Down

0 comments on commit 617cc4d

Please sign in to comment.