addressing PR comments

optimizely · Apr 23, 2020 · 702ff3f · 702ff3f
1 parent 540e2f5
commit 702ff3f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/optimizely/helpers/enums.py b/optimizely/helpers/enums.py
@@ -75,7 +75,7 @@ class DecisionNotificationTypes(object):
     FEATURE = 'feature'
     FEATURE_TEST = 'feature-test'
     FEATURE_VARIABLE = 'feature-variable'
-    FEATURE_VARIABLES = 'feature-variables'
+    ALL_FEATURE_VARIABLES = 'all-feature-variables'
 
 
 class DecisionSources(object):

diff --git a/optimizely/optimizely.py b/optimizely/optimizely.py
@@ -365,7 +365,7 @@ def _get_all_feature_variables_for_type(
 
         self.notification_center.send_notifications(
             enums.NotificationTypes.DECISION,
-            enums.DecisionNotificationTypes.FEATURE_VARIABLES,
+            enums.DecisionNotificationTypes.ALL_FEATURE_VARIABLES,
             user_id,
             attributes or {},
             {
@@ -764,7 +764,7 @@ def get_feature_variable_string(self, feature_key, variable_key, user_id, attrib
         )
 
     def get_feature_variable_json(self, feature_key, variable_key, user_id, attributes=None):
-        """ Returns value for a certain json variable attached to a feature.
+        """ Returns value for a certain JSON variable attached to a feature.
 
     Args:
       feature_key: Key of the feature whose variable's value is being accessed.
@@ -790,15 +790,15 @@ def get_feature_variable_json(self, feature_key, variable_key, user_id, attribut
         )
 
     def get_all_feature_variables(self, feature_key, user_id, attributes=None):
-        """ Returns dictionary of all variables attached to a feature.
+        """ Returns dictionary of all variables and their corresponding values in the context of a feature.
 
     Args:
       feature_key: Key of the feature whose variable's value is being accessed.
       user_id: ID for user.
       attributes: Dict representing user attributes.
 
     Returns:
-      Dictionary object of the variable. None if:
+      Dictionary mapping variable key to variable value. None if:
       - Feature key is invalid.
     """
 

diff --git a/tests/test_optimizely.py b/tests/test_optimizely.py
@@ -2599,7 +2599,7 @@ def test_get_all_feature_variables(self):
 
         mock_broadcast_decision.assert_called_once_with(
             enums.NotificationTypes.DECISION,
-            'feature-variables',
+            'all-feature-variables',
             'test_user',
             {},
             {
@@ -3006,7 +3006,7 @@ def test_get_all_feature_variables_for_feature_in_rollout(self):
         )
         mock_broadcast_decision.assert_called_once_with(
             enums.NotificationTypes.DECISION,
-            'feature-variables',
+            'all-feature-variables',
             'test_user',
             {'test_attribute': 'test_value'},
             {
@@ -3253,7 +3253,7 @@ def test_get_feature_variable__returns_default_value_if_variable_usage_not_in_va
         )
         mock_config_logger.info.reset_mock()
 
-        # json
+        # JSON
         with mock.patch(
             'optimizely.decision_service.DecisionService.get_variation_for_feature',
             return_value=decision_service.Decision(mock_experiment, mock_variation, enums.DecisionSources.FEATURE_TEST),
@@ -3460,7 +3460,7 @@ def test_get_feature_variable__returns_default_value_if_no_variation(self):
 
         mock_client_logger.info.reset_mock()
 
-        # json
+        # JSON
         with mock.patch(
             'optimizely.decision_service.DecisionService.get_variation_for_feature',
             return_value=decision_service.Decision(None, None, enums.DecisionSources.ROLLOUT),
@@ -3961,7 +3961,7 @@ def test_get_feature_variable__returns_default_value_if_feature_not_enabled(self
             'Returning the default variable value "devel".'
         )
 
-        # json
+        # JSON
         with mock.patch(
             'optimizely.decision_service.DecisionService.get_variation_for_feature',
             return_value=decision_service.Decision(mock_experiment, mock_variation, enums.DecisionSources.FEATURE_TEST),
@@ -4087,7 +4087,7 @@ def test_get_feature_variable__returns_default_value_if_feature_not_enabled_in_r
             'Returning the default variable value "Hello".'
         )
 
-        # json
+        # JSON
         with mock.patch(
             'optimizely.decision_service.DecisionService.get_variation_for_feature',
             return_value=decision_service.Decision(mock_experiment, mock_variation, enums.DecisionSources.ROLLOUT),