Skip to content

Commit

Permalink
Removed basestring as this is not supported by Python3.
Browse files Browse the repository at this point in the history
  • Loading branch information
alda-optimizely committed Sep 12, 2017
1 parent b64865c commit ac066d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion optimizely/helpers/event_tag_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def get_numeric_value(event_tags, logger=None):
else:
numeric_metric_value = event_tags[NUMERIC_METRIC_TYPE]
try:
if isinstance(numeric_metric_value, (numbers.Integral, float, basestring)):
if isinstance(numeric_metric_value, (numbers.Integral, float, str)):
# Attempt to convert the numeric metric value to a float
cast_numeric_metric_value = float(numeric_metric_value)

Expand Down

0 comments on commit ac066d0

Please sign in to comment.