Merge branch 'master' into sohail/pr-193

optimizely · Sep 16, 2019 · b5d461b · b5d461b
2 parents c3d5b07 + 547a13c
commit b5d461b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/optimizely/config_manager.py b/optimizely/config_manager.py
@@ -239,8 +239,8 @@ def set_update_interval(self, update_interval):
                 'Invalid update_interval "{}" provided.'.format(update_interval)
             )
 
-        # If polling interval is less than minimum allowed interval then set it to default update interval.
-        if update_interval < enums.ConfigManager.MIN_UPDATE_INTERVAL:
+        # If polling interval is less than or equal to 0 then set it to default update interval.
+        if update_interval <= 0:
             self.logger.debug('update_interval value {} too small. Defaulting to {}'.format(
                 update_interval,
                 enums.ConfigManager.DEFAULT_UPDATE_INTERVAL)

diff --git a/optimizely/helpers/enums.py b/optimizely/helpers/enums.py
@@ -40,8 +40,6 @@ class ConfigManager(object):
   DATAFILE_URL_TEMPLATE = 'https://cdn.optimizely.com/datafiles/{sdk_key}.json'
   # Default config update interval of 5 minutes
   DEFAULT_UPDATE_INTERVAL = 5 * 60
-  # Minimum config update interval of 1 second
-  MIN_UPDATE_INTERVAL = 1
   # Time in seconds before which request for datafile times out
   REQUEST_TIMEOUT = 10
 

diff --git a/tests/test_config_manager.py b/tests/test_config_manager.py
@@ -224,7 +224,7 @@ def test_set_update_interval(self, _):
             project_config_manager.set_update_interval('invalid interval')
 
         # Assert that update_interval cannot be set to less than allowed minimum and instead is set to default value.
-        project_config_manager.set_update_interval(0.42)
+        project_config_manager.set_update_interval(-4.2)
         self.assertEqual(enums.ConfigManager.DEFAULT_UPDATE_INTERVAL, project_config_manager.update_interval)
 
         # Assert that if no update_interval is provided, it is set to default value.