explicitly check for None

optimizely · Jan 18, 2018 · ef0c0ee · ef0c0ee
1 parent c19c18e
commit ef0c0ee
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/optimizely/optimizely.py b/optimizely/optimizely.py
@@ -198,15 +198,15 @@ def _get_feature_variable_for_type(self, feature_key, variable_key, variable_typ
       - Variable key is invalid.
       - Mismatch with type of variable.
     """
-    if not feature_key:
+    if feature_key is None:
       self.logger.log(enums.LogLevels.ERROR, enums.Errors.NONE_FEATURE_KEY_PARAMETER)
       return None
 
-    if not variable_key:
+    if variable_key is None:
       self.logger.log(enums.LogLevels.ERROR, enums.Errors.NONE_VARIABLE_KEY_PARAMETER)
       return None
 
-    if not user_id:
+    if user_id is None:
       self.logger.log(enums.LogLevels.ERROR, enums.Errors.NONE_USER_ID_PARAMETER)
       return None
 
@@ -386,11 +386,11 @@ def is_feature_enabled(self, feature_key, user_id, attributes=None):
       self.logger.log(enums.LogLevels.ERROR, enums.Errors.INVALID_DATAFILE.format('is_feature_enabled'))
       return False
 
-    if not feature_key:
+    if feature_key is None:
       self.logger.log(enums.LogLevels.ERROR, enums.Errors.NONE_FEATURE_KEY_PARAMETER)
       return False
 
-    if not user_id:
+    if user_id is None:
       self.logger.log(enums.LogLevels.ERROR, enums.Errors.NONE_USER_ID_PARAMETER)
       return False