ci: Replace pep8 by flake8 and separate linting stage on Travis #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
aliabbasrizvi
approved these changes
Jan 11, 2019
.travis.yml
Outdated
| @@ -8,7 +8,7 @@ python: | |||
| - "pypy" | |||
| - "pypy3" | |||
| install: "pip install -r requirements/core.txt;pip install -r requirements/test.txt" | |||
| before_script: "pep8" | |||
| before_script: skip | |||
There was a problem hiding this comment.
nit. This can be removed right?
.travis.yml
Outdated
| @@ -17,12 +17,21 @@ after_success: | |||
|
|
|||
| # Integration tests need to run first to reset the PR build status to pending | |||
There was a problem hiding this comment.
Please change this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements flake8 which is a wrapper over pyflakes, pycodestyle(PEP8), and circular complexity checks.
Also, the linting stage has been separated so that it immediately fails the build rather than creating separate environments for multiple python versions and failing all the jobs for the same reason.
Test plan
Issues