Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DecisionListener): Adds feature decision listener. #169

Merged
merged 5 commits into from
Apr 2, 2019
Merged

feat(DecisionListener): Adds feature decision listener. #169

merged 5 commits into from
Apr 2, 2019

Conversation

rashidsp
Copy link
Contributor

Summary

Implemented onDecisionListener in following APIs:

  • is_feature_enabled
  • get_enabled_features

Test plan

Unit tests for DecisionListener

Issues

  • OASIS-4351

@coveralls
Copy link

coveralls commented Mar 28, 2019 •
edited

Coverage Status

Coverage increased (+0.002%) to 99.712% when pulling c6c2b48 on oakbani/decision-is-feat-enabled into 1f34b2a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.71% when pulling a5771c7 on oakbani/decision-is-feat-enabled into f772ecc on master.

@rashidsp rashidsp requested a review from a team April 1, 2019 11:46
aliabbasrizvi
aliabbasrizvi approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliabbasrizvi aliabbasrizvi merged commit e4d949a into master Apr 2, 2019
@aliabbasrizvi aliabbasrizvi deleted the oakbani/decision-is-feat-enabled branch April 2, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rashidsp @coveralls @aliabbasrizvi @oakbani