Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue in logger #183

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Fixing issue in logger #183

merged 1 commit into from
Jun 18, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

Summary

Logger in config_manager was being initialized incorrectly. Fixing that.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 98.756% when pulling 6aea698 on ali/fix_logging_issue into b37f0d4 on datafile-manager.

mikeproeng37
mikeproeng37 approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mikeproeng37
mikeproeng37 approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, silly mistake. Ship it!

@aliabbasrizvi aliabbasrizvi merged commit 251b65f into datafile-manager Jun 18, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/fix_logging_issue branch June 18, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@Mat001 Mat001 Awaiting requested review from Mat001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aliabbasrizvi @coveralls @mikeproeng37