feat(event_processor): add forwarding event processor and integrate with optimizely #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ------- - Introduces an EventProcessor interface. - Introduces a BatchEventProcessor Buffering events within a queue before dispatching is an optimization that should prevent SDK implementations from exhausting resources while increasing throughput. This implementation relies on a BlockingCollection to buffer events received from one-to-many producers. A single consumer thread continuously polls from this queue to build a batch before emitting the batched LogEvent. Test plan --------- - Added unit tests.
# Conflicts: # optimizely/event/entity/conversion_event.py # optimizely/event/entity/decision.py # optimizely/event/entity/event_context.py # optimizely/event/entity/impression_event.py
# Conflicts: # optimizely/event/entity/user_event.py # optimizely/event/entity/visitor.py
…into mnoman/AddBatchEP
# Conflicts: # optimizely/event/event_processor.py
…/python-sdk into mnoman/log_event_notification
…vent_processor # Conflicts: # optimizely/event/event_processor.py
aliabbasrizvi
suggested changes
Sep 24, 2019
optimizely/event/event_processor.py
Outdated
| The ForwardingEventProcessor sends the LogEvent to EventDispatcher as soon as it is received. | ||
| """ | ||
|
|
||
| def __init__(self, event_dispatcher, logger, notification_center=None): |
There was a problem hiding this comment.
logger should be optional and we should set it to NoOpLogger if not provided.
|
|
||
| Args: | ||
| event_dispatcher: Provides a dispatch_event method which if given a URL and params sends a request to it. | ||
| logger: Optional component which provides a log method to log messages. By default nothing would be logged. |
There was a problem hiding this comment.
You say it is optional, but it is not so in practice.
| """ | ||
| self.event_dispatcher = event_dispatcher | ||
| self.logger = logger | ||
| self.notification_center = notification_center |
There was a problem hiding this comment.
Similar to feedback in #204 shouldn't we validate that notification_center is an instance of notification_center.NotificationCenter
| @@ -43,7 +43,7 @@ class InvalidGroupException(Exception): | |||
|
|
|||
|
|
|||
| class InvalidInputException(Exception): | |||
| """ Raised when provided datafile, event dispatcher, logger or error handler is invalid. """ | |||
| """ Raised when provided datafile, event dispatcher, logger, event processor or error handler is invalid. """ | |||
There was a problem hiding this comment.
nit. Year in header needs to be updated.
|
@msohailhussain Have fixed a failing FSC test in this PR.
|
…arding_event_processor
|
Latest Event Batching Travis Build with Event Batching Testapp Branch https://travis-ci.com/optimizely/fullstack-sdk-compatibility-suite/builds/130617595 |
|
Should pass once #211 is merged |
aliabbasrizvi
approved these changes
Oct 10, 2019
tests/test_optimizely.py
Outdated
| self.assertTrue(isinstance(event, event_builder.Event)) | ||
|
|
||
| # TODO: what should be done about passing dicts of class instances? | ||
| # self.assertTrue(isinstance(event, LogEvent)) |
There was a problem hiding this comment.
Why is this commented? Can we remove the print statement in the next line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan