Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add auth datafile config manager documentation and refactor README #277

Merged
merged 6 commits into from
Jun 29, 2020

Conversation

pthompson127
Copy link
Contributor

Summary

  • Added documentation for AuthDatafilePollingConfigManager
  • Updated link line numbers of Config Managers in README
  • Reordered parameter and descriptions to stay consistent with that in class constructors

Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address feedback before merging.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/source/config_manager.rst Outdated Show resolved Hide resolved
@pthompson127 pthompson127 removed their assignment Jun 29, 2020
@coveralls
Copy link

coveralls commented Jun 29, 2020

Coverage Status

Coverage remained the same at 97.089% when pulling a72fb74 on peter/auth-datafile-docs into d743410 on master.

@pthompson127 pthompson127 merged commit 3af111d into master Jun 29, 2020
@pthompson127 pthompson127 deleted the peter/auth-datafile-docs branch June 29, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants