Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run source clear before linting and tests. #292

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Jul 24, 2020

Summary

Stages run sequentially on Travis. If a stage fails, all the following stages are not executed. We execute source clear only on cron, and if due to any reason unit or integration tests fail, the source clear is not executed. Hence, moving source clear stage before tests.

Test plan

All unit tests must be passed.
FSC must be passed.

@oakbani oakbani removed their assignment Jul 24, 2020
@oakbani oakbani changed the title ci: Run source clear before integration and unit tests ci: Run source clear before linting and tests. Jul 24, 2020
@coveralls
Copy link

coveralls commented Jul 24, 2020

Coverage Status

Coverage remained the same at 97.154% when pulling 21fe36b on oakbani/run-srcclr-before-tests into a601426 on master.

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain marked this pull request as ready for review July 28, 2020 21:08
@msohailhussain msohailhussain requested a review from a team as a code owner July 28, 2020 21:08
@aliabbasrizvi aliabbasrizvi merged commit ce0827d into master Jul 29, 2020
@aliabbasrizvi aliabbasrizvi deleted the oakbani/run-srcclr-before-tests branch July 29, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants