Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OASIS-7552] fix: update requests library dependency #330

Merged
merged 9 commits into from Jun 29, 2021
Merged

[OASIS-7552] fix: update requests library dependency #330

merged 9 commits into from Jun 29, 2021

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Jun 2, 2021

Summary

  • breaking down module requests[security] into its libraries because requests[security] will no longer be supported with requests version 2.26.
  • I unpacked it into libraries: requests, pyOpenSSL, cryptography, idna. Looked for highest versions that work on all Py versions in the SDK (common denominator that works across all Py versions that we support in our SDK)

The “why”, or other context.

Test plan

  • FSC compatibility tests passing

Issues

@Mat001 Mat001 requested a review from a team as a code owner June 2, 2021 16:28
@Mat001 Mat001 changed the title Mpirnovar/update requests [OASIS-7552] fix: update requests library dependency Jun 2, 2021
@coveralls
Copy link

coveralls commented Jun 2, 2021 •
edited

Coverage Status

Coverage remained the same at 95.975% when pulling 9c4c094 on mpirnovar/update_requests into 2ee24cf on master.

jaeopt
jaeopt approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but not completely sure about implications.
We better get it confirmed with the python team.

@Mat001
Copy link
Contributor Author

Mat001 commented Jun 4, 2021

It looks good to me, but not completely sure about implications.
We better get it confirmed with the python team.

good point

@Mat001 Mat001 merged commit 7cc2bde into master Jun 29, 2021
@Mat001 Mat001 deleted the mpirnovar/update_requests branch June 29, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-inside-man The-inside-man The-inside-man approved these changes

@jaeopt jaeopt jaeopt approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees

@Mat001 Mat001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mat001 @coveralls @The-inside-man @jaeopt