[MAINTENANCE] Cleanup: Removed depreicated warnings relating to test … #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cases. assertRaisesRegexp -> assertRaisesRegex, assertEquals -> assertEqual, and isAlive() -> isAlive().
|
looks like Python 2.7, pypy and pypy3 have issues with the newer items.
Looks to have no issue with the isAlive() to is_alive() change across all versions. |
…t for Earlier Python versions pre 3.3
|
Will do more research on how to make compatible with older versions of python and come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Noticed many warnings related to deprecated usage.
Updated to the Python recommended versions.
assertRaisesRegexp -> assertRaisesRegex, assertEquals -> assertEqual, and isAlive() -> isAlive()
Test plan
Run through tests with prior Python versions for compatibility generated from this PR.
Issues
Not attached to any Jira