Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk_key and environment_key support #338

Merged
merged 6 commits into from
Jun 23, 2021
Merged

sdk_key and environment_key support #338

merged 6 commits into from
Jun 23, 2021

Conversation

The-inside-man
Copy link
Contributor

@The-inside-man The-inside-man commented Jun 17, 2021 •
edited
Loading

Summary

  • Added test cases to improve coverage
  • Fixed spelling mistakes in environment_key
  • sdk_key and environment_key support added for optimizely_config

Test plan

  • Compatibility test suite and compliance tests

Issues

  • OASIS-7757

ozayr-zaviar and others added 4 commits June 17, 2021 14:28
@ozayr-zaviar @The-inside-man
added sdk and environment key
5ee1748
@The-inside-man
[MAINTENANCE] Remove Deprecated warnings during build
aca3015 
            - assertRaisesRegexp -> assertRaisesRegex
            - assertEquals -> assertEqual
            - isAlive() -> is_alive()
            - Check added to base.py to confirm attribute assertRaisesRegex for backwards compatibility to Python2.7
@The-inside-man
[OASIS-7757] Fix spelling of environment to fix testcases from failing
64a2899
@The-inside-man
[OASIS-7757] - Added additional test cases to test_optimizely and tes…
996584a 
…t_user_context.
@The-inside-man The-inside-man requested a review from a team as a code owner June 17, 2021 19:05
@The-inside-man The-inside-man removed the request for review from a team June 17, 2021 19:05
@coveralls
Copy link

coveralls commented Jun 17, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 95.931% when pulling 6b3bf40 on jbrown/oasis-7757_python-testcases into c3b191b on master.

@The-inside-man The-inside-man requested review from jaeopt and a team June 22, 2021 13:40
jaeopt
jaeopt approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion

tests/test_optimizely.py Outdated Show resolved Hide resolved
@The-inside-man The-inside-man changed the title Jbrown/oasis 7757 python testcases sdk_key and environment_key Spelling Correction Jun 22, 2021
@The-inside-man The-inside-man changed the title sdk_key and environment_key Spelling Correction environment_key Spelling Correction Jun 22, 2021
@The-inside-man The-inside-man changed the title environment_key Spelling Correction sdk_key and environment_key support Jun 22, 2021
msohailhussain
msohailhussain requested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some more unit tests, asserting sdkKey and environmentKey other than None values.

@The-inside-man
[OASIS-7757] - update copyright years and add more testcases for sdk_…
6b3bf40 
…key and environment_key. Move decide tests to test_user_context from test_optimizely.
msohailhussain
msohailhussain approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@The-inside-man The-inside-man merged commit 9e9c4d0 into master Jun 23, 2021
@The-inside-man The-inside-man deleted the jbrown/oasis-7757_python-testcases branch June 23, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@The-inside-man The-inside-man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@The-inside-man @coveralls @msohailhussain @jaeopt @ozayr-zaviar