Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add six dependency to requirements/core.txt #363

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

The-inside-man
Copy link
Contributor

@The-inside-man The-inside-man commented Nov 9, 2021

Summary

  • Add six dependency as it was missing from requirements/core.txt

Note: This library is used throughout the core functionality of the SDK, however the build did not fail previously due to the six library being a transient dependency for jsonschema. Jsonschema is already in requirements/core.txt, however, we are now choosing to explicitly require the six dependency as we use this library explicitly in our SDK.

Test plan

  • FSC

Issues

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.088% when pulling 0d6c2e6 on jbrown/add-six-dependancy into a1e31eb on master.

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. per our discussion need to add description in the summary.

@The-inside-man The-inside-man merged commit 4119778 into master Dec 7, 2021
@The-inside-man The-inside-man deleted the jbrown/add-six-dependancy branch December 7, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants