fix: Forced variation not available in experiment #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
approved these changes
Dec 13, 2021
ozayr-zaviar
changed the title
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
jaeopt
requested changes
Dec 15, 2021
tests/test_user_event_factory.py
Outdated
| impression_event = UserEventFactory.create_impression_event( | ||
| project_config, None, '111128', 'flag_key', 'rule_key', 'rule_type', True, user_id, user_attributes | ||
| ) | ||
| self.assertIsNone(impression_event) |
There was a problem hiding this comment.
this should not be none. With FD, {None experiment} is a valid case, for which we should forward the impression event.
| if not variation and variation_id and experiment_id: | ||
| # need this condition when we send events involving forced decisions | ||
| elif variation_id and experiment_id: | ||
| # need this condition when we send events involving forced decisions (F-to-D or E-to-D with any ruleKey/variationKey combinations) |
There was a problem hiding this comment.
Move this comment line to the top of line 52.
There was a problem hiding this comment.
Can we have a unit test covering this bug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan