Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Debug logging changed to info #368

Merged
merged 1 commit into from
Dec 14, 2021
Merged

feat: Debug logging changed to info #368

merged 1 commit into from
Dec 14, 2021

Conversation

ozayr-zaviar
Copy link
Contributor

@ozayr-zaviar ozayr-zaviar commented Dec 13, 2021 •
edited
Loading

Summary

  • Forced decision logging updated to info from debug.

Test plan

  • All testcases and FSC should pass.

@msohailhussain msohailhussain marked this pull request as ready for review December 13, 2021 21:52
@msohailhussain msohailhussain requested a review from a team as a code owner December 13, 2021 21:52
jaeopt
jaeopt approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

msohailhussain
msohailhussain approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. appreciate if you add unit test for logs as well.

@msohailhussain msohailhussain merged commit c6fd795 into master Dec 14, 2021
@msohailhussain msohailhussain deleted the uzair/logging-fix branch December 14, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@ozayr-zaviar ozayr-zaviar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ozayr-zaviar @Mat001 @msohailhussain @jaeopt