Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add odp config #401

Merged
merged 7 commits into from
Aug 22, 2022
Merged

feat: add odp config #401

merged 7 commits into from
Aug 22, 2022

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

Config for managing odp integration

Test plan

  • added test_odp_config.py

Ticket

OASIS-8405
OASIS-8442

@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner August 19, 2022 14:17
Mat001
Mat001 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

optimizely/odp/odp_config.py Outdated Show resolved Hide resolved
optimizely/odp/odp_config.py Outdated Show resolved Hide resolved
optimizely/odp/odp_config.py Outdated Show resolved Hide resolved
optimizely/odp/odp_config.py Show resolved Hide resolved
jaeopt
jaeopt approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a possible clean up

optimizely/odp/odp_config.py Outdated Show resolved Hide resolved
@andrewleap-optimizely andrewleap-optimizely merged commit 81a5bfe into master Aug 22, 2022
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/add_odp_config branch August 22, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewleap-optimizely @Mat001 @jaeopt