refactor: remove odp config from constructors #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewleap-optimizely
changed the title
Mat001
requested changes
Sep 26, 2022
| @@ -217,6 +219,10 @@ def stop(self) -> None: | |||
|
|
|||
| def send_event(self, type: str, action: str, identifiers: dict[str, str], data: OdpDataDict) -> None: | |||
| """Create OdpEvent and add it to the event queue.""" | |||
| if not self.odp_config: | |||
| self.logger.debug('ODP event queue: cannot send before config has been set.') | |||
There was a problem hiding this comment.
Might be nice to have a test/ assertion for this new log?
andrewleap-optimizely
deleted the
aleap/remove_odp_config_from_constructors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
all tests pass
Ticket