fix: block odp methods on datafile #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
approved these changes
Mar 10, 2023
optimizely/optimizely.py
Outdated
Comment on lines
1360
to
1362
| if not self.odp_manager.enabled: | ||
| self.logger.debug('ODP identify event is not dispatched (ODP disabled).') | ||
| return |
There was a problem hiding this comment.
I believe this is checked in odp_manager. Do we need to check here again?
There was a problem hiding this comment.
This allows create_user_context to remain non-blocking if odp is disabled. Seems like a worthwhile optimization?
There was a problem hiding this comment.
@andrewleap-optimizely I see. Probably not in server sdks. They'll be blocked anyway in following decide call even if avoid it here :)
Mat001
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimizely._identify,Optimizely._fetch_qualified_segmentsandOptimizely.send_odp_eventto ensure datafile has been downloaded before attempting to make odp requests.Test plan
all existing tests pass