New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added useCallback to getCurrentDecision in useDecision hook #184

Open

monahans wants to merge 1 commit into optimizely:master from monahans:master

monahans commented Oct 5, 2022

adding useCallback here fixed a few things:

Bug: if you used multiple useDecision hooks with { autoUpdate: true }, the second one would not autoUpdate (you had to fully reload the app to get the decision to update)
Before it was redefining getCurrentDecision on every rerender of the useDecision hook, which decreased performance


          added useCallback to getCurrentDecision in useDecision hook

c5eb9d1

optimizely-codereview-bot assigned monahans

Contributor

mikechu-optimizely commented Aug 28, 2023

This seems to relate to #196 and (now) internal ticket FSSDK-9624

mikechu-optimizely added the acknowledged label

mikechu-optimizely mentioned this pull request

Stale closure bug in useDecision #170

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment