Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9494] Correction to release workflow #216

Merged
merged 4 commits into from
Sep 25, 2023
Merged

[FSSDK-9494] Correction to release workflow #216

merged 4 commits into from
Sep 25, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Fixes the release GitHub workflow for publishing to NPM

Test plan

  • All existing tests should continue to succeed since no SDK code paths changed.

Issues

  • FSSDK-9494

@mikechu-optimizely mikechu-optimizely added the bug Something isn't working label Sep 25, 2023
raju-opti
raju-opti approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikechu-optimizely mikechu-optimizely merged commit e79175d into master Sep 25, 2023
5 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/fix-release-process branch September 25, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikechu-optimizely @raju-opti