Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ats): add ODP integration #455

Merged
merged 116 commits into from
Oct 21, 2022
Merged

feat(ats): add ODP integration #455

merged 116 commits into from
Oct 21, 2022

Conversation

jaeopt
Copy link
Collaborator

@jaeopt jaeopt commented Apr 19, 2022 •
edited
Loading

Summary

This PR adds a support for Optimizely Data Platform (ODP) integration to Full Stack. With this extension, clients may not need to pre-determine and include user segments in attributes. SDK can fetch user segments from the ODP server for the current user.

  • Add a new public API to OptimizelyUserContext (fetchQualifiedSegments).
  • Add a ODP server interface (segments and events).
  • Add a new audience type (qualified).
  • Add VuidManager and support vuid-based decisions before userId is available.

Test plan

  • Tests for OptimizelyUserContext new APIs.
  • Tests for odpManager.
  • Tests for new audience type (qualified).
  • Tests for vuid persistence and vuid-based decisions.

Issues

  • FSSDK-8413

@jaeopt
wip
60f0a2d
@jaeopt
recover sample app
6c01e73
@jaeopt
Merge branch 'master' into jae/list-target
ca76a1d
@jaeopt
add optional AudienceSegmentsHandler
a0ec550
@jaeopt
clean up audience segments
1bd224a
@jaeopt
add config params
f68e7d3
@jaeopt
add tests for OptimizelyUserContext + ATS
ce958bc
@jaeopt
add protocol for AudienceSegmentsHandler
d5721b3
@jaeopt
more tests for segments
5fb8a20
@jaeopt
add segments to audience
619d524
@jaeopt
Merge branch 'master' into jae/list-target
3a441e0
@jaeopt
add segments tests
e9a026b
@jaeopt
add tests for ATS
e43cbf6
@jaeopt
add segmentsToCheck filtering
553a350
@jaeopt
thread-safe audienceSegmentsHandler
cc28acb
@jaeopt
clean up
afd0e83
@jaeopt
add segmentsToCheck support
532656b
@jaeopt
add useSubset option
6a4ef83
@jaeopt
add performance test for user context
bb541f7
@jaeopt
clean up user context
4e524f1
@jaeopt
clean up user context synchronizations
6d0ea43
@jaeopt
add user context performance tests
12cd3a8
@jaeopt
fix fetch api to return segments in completion handler
4eea2af
@jaeopt
clean up
71e6fa6
@jaeopt jaeopt requested a review from a team as a code owner April 19, 2022 21:20
yasirfolio3
yasirfolio3 suggested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some minor changes suggested.

Sources/ODP/OdpSegmentManager.swift Outdated Show resolved Hide resolved
Tests/OptimizelyTests-DataModel/ProjectConfigTests.swift Show resolved Hide resolved
Tests/TestData/odp/decide_audience_segments.json Outdated Show resolved Hide resolved
Sources/Optimizely+Decide/OptimizelyUserContext.swift Show resolved Hide resolved
Tests/OptimizelyTests-Common/OptimizelyUserContextTests_ODP.swift Show resolved Hide resolved
Sources/ODP/ZaiusGraphQLApiManager.swift Outdated Show resolved Hide resolved
Sources/ODP/OdpEventManager.swift Outdated Show resolved Hide resolved
Sources/ODP/OdpEventManager.swift Outdated Show resolved Hide resolved
Sources/ODP/OdpEventManager.swift Outdated Show resolved Hide resolved
Tests/OptimizelyTests-Common/OdpManagerTests.swift Outdated Show resolved Hide resolved
yasirfolio3
yasirfolio3 previously approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yasirfolio3
yasirfolio3 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 2fcbc11 into master Oct 21, 2022
@jaeopt jaeopt deleted the jae/ats branch October 21, 2022 16:49
@jaeopt jaeopt changed the title feat: add ODP integration feat(odp): add ODP integration Oct 28, 2022
@jaeopt jaeopt changed the title feat(odp): add ODP integration feat(ats): add ODP integration Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasirfolio3 yasirfolio3 yasirfolio3 approved these changes

@Mat001 Mat001 Awaiting requested review from Mat001

@andrewleap-optimizely andrewleap-optimizely Awaiting requested review from andrewleap-optimizely

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jaeopt @coveralls @Mat001 @yasirfolio3 @andrewleap-optimizely @optimizely-codereview-bot