-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pagination to frontpage #18
Comments
I am working on this over at Maurice22/quarantine-hero@8c87da33746d67563e31d7301e4606f0f6bb3d1e |
So there is an issue: If we use pagination, client-side filtering of locations does not work anymore (as we won't search the whole database). I wanted to fix this by filtering the location on the database as well but it turns out that more or less firebase only allows for one filter. Because of that I would suggest to disable pagination if a user searches for a location. What do you think? Do you have other ideas? |
@Maurice22 Yes thats a problem but it also means we significantly reduce reads. |
@kenodressel Please check out my version at Maurice22/quarantine-hero@383f2c7246739be42cff0dc542c75cfca004a6ba . I completely redesigned the way queries are done, including support when maps API is enabled. Can you give it a test? If everything works fine, I will create a PR for it. |
Ah yeah and of course I added pagination there :D Check the commit messages for more info. |
I took a look and it seems fine to me. You can post a PR. Are you available for a call (send mail to help@quarantaenehelden.org) so we can include you better in our planning? |
Closed in #46 |
Cloud Firestore has several features to help you manage queries that return a large number of results:
The text was updated successfully, but these errors were encountered: