Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Feature #46

Merged
merged 9 commits into from
Mar 19, 2020
Merged

Pagination Feature #46

merged 9 commits into from
Mar 19, 2020

Conversation

mauriceackel
Copy link
Member

Implements #18

Also redesigns the way requests are filtered by filtering them server-side.

@kenodressel Might this be counterproductive in terms of readcount?

…y (pageSize). If > 0, pagination with this page size is enabled. Pagination gets disabled as a search is done.

Also, filtering is now implemented server-side, due to a complete rewrite of the query (i.e. introducing a query builder)
@mauriceackel
Copy link
Member Author

@kenodressel Now on the most recent version. I also added a "ScrollToTop"-Button component from npm that is visible on all sites as soon as you start scrolling down.

src/components/FilteredList.js Outdated Show resolved Hide resolved
src/components/FilteredList.js Outdated Show resolved Hide resolved
src/components/FilteredList.js Outdated Show resolved Hide resolved
@mauriceackel
Copy link
Member Author

@kenodressel Changes incorporated

@kenodressel kenodressel self-requested a review March 19, 2020 22:10
@kenodressel kenodressel merged commit 435e66e into master Mar 19, 2020
@kenodressel kenodressel deleted the feature/pagination branch March 19, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants