-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add reporting feature #65
WIP: add reporting feature #65
Conversation
@@ -41,6 +42,45 @@ export default function Entry(props) { | |||
setDeleted(true); | |||
}; | |||
|
|||
const reportEntry = async event => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be lovely if someone with more firebase knowledge than me could double-check this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here my ideas to simplify it:
Use documentRef.set
this is the upsert function
To add a uid to the array we could use https://cloud.google.com/firestore/docs/manage-data/add-data#update_elements_in_an_array
Then this can all be done in one query.
@kenodressel updated. I see that the develop branch is set as the new default, should I rebase the PR against it? |
@jagaSto yes please :) |
I'll make a new PR since |
I think this makes sense |
WIP due to the following issues
/offer-help/:postingId
--> any suggestions?Video Recording