-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check if certificates is empty strings #105
Conversation
@e-max What about using a string instead of a |
That way the caller doesn't have to cast anything and can directly pass a value from |
Also, do we need tests for this change? |
Why is the update of certificates in tests necessary? Edit, based on slack exchange:
|
arr. Guthub stopped to send me an email again! I missed all your comments @dgellow . Sorry about it. |
Kafka driver enable TLS connection if user passed key and certificate. Before we consider any certificate valid if it wasn't nil. In this PR we check if it also not empty string