Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems that handle taps do not work 0.3.7 #38

Closed
ghost opened this issue Jan 3, 2016 · 11 comments
Closed

It seems that handle taps do not work 0.3.7 #38

ghost opened this issue Jan 3, 2016 · 11 comments

Comments

@ghost
Copy link

ghost commented Jan 3, 2016

Thank you guys! It's the best what I've seen!
So I'm not sure but it seems like handles do not work in 0.3.7. I downloaded and compiled source code folder 0.3.7 and 0.3.6. In 0.3.6 handleMentionTap, handleHashtagTap, handleURLTap working as expected. In 0.3.7 they don't work.

@polqf
Copy link
Contributor

polqf commented Jan 3, 2016

What do you mean by "they don't work as expected"? Could you tell us where are you adding the label and what do you set to it?

@ghost
Copy link
Author

ghost commented Jan 3, 2016

screen shot 2016-01-03 at 06 24 12
methods:
screen shot 2016-01-03 at 06 28 33

@ghost
Copy link
Author

ghost commented Jan 3, 2016

I mean UIAlertController doesn't appear

@ghost
Copy link
Author

ghost commented Jan 3, 2016

Maybe I'm doing something wrong, maybe these methods really don't work. Check it just in case please.

@polqf
Copy link
Contributor

polqf commented Jan 3, 2016

Yesterday I was working with ActiveLabel in the example project, and everything was working fine for me, alerts where being shown...

What Xcode version are you using?
Have you tried it in the example or in you own app?

@ghost
Copy link
Author

ghost commented Jan 4, 2016

Xcode 7.2. It seems the problem is strange positioning of ActiveLabel and behaviour UITouch. I recorded the screencast: https://vimeo.com/150638370
Now I use 0.3.6 and it works fine. So If it's only my problem, I think we could close this issue. And I'll just continue to use 0.3.6.

@polqf
Copy link
Contributor

polqf commented Jan 4, 2016

That's really strange, have you tried changing the zoom in the simulator to see the full screen?

I'll take a deeper look when I can, and I'll tell you something

@ghost
Copy link
Author

ghost commented Jan 4, 2016

I think the problem is the arbitrary height of ActiveLabel: https://vimeo.com/150716211

@polqf
Copy link
Contributor

polqf commented Jan 4, 2016

Wow, you are totally correct. I now see the point!
The thing is that is not taking the inset in account. I'll take a look at it right now

@polqf
Copy link
Contributor

polqf commented Jan 4, 2016

Could you check the referenced PR, I think it is now doing what is expected

@ghost
Copy link
Author

ghost commented Jan 5, 2016

Yes, I checked it. Now all works great! With labels of any height! Thank you!

@polqf polqf closed this as completed in #39 Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant