Correcting location when tapping on the label #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed by @dimanicholson that it is fixing the issue |
polqf
added a commit
that referenced
this pull request
Jan 5, 2016
Correcting location when tapping on the label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Since #35 , the location of the touch was not precise if the height of the label was bigger than the height of the text.
Thanks @dimanicholson for your patience and your videos explaining the issue ( #38 )
The reason why it is happening is that
boundingRectForGlyphRangeis returning a CGRect on the origin, so it is only working now for labels that have the same size as the bounding rect of the text.This PR introduces a correction to the tap location in order to avoid this problem on that situation.
馃懟 GIF
Closes #38