Add mention and hashtag filtering #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,6 +166,9 @@ public protocol ActiveLabelDelegate: class { | |||
| private var mentionTapHandler: ((String) -> ())? | |||
| private var hashtagTapHandler: ((String) -> ())? | |||
| private var urlTapHandler: ((NSURL) -> ())? | |||
|
|
|||
| private var mentionFilterPredicate: ((String) -> Bool) = { _ in return false } | |||
| private var hashtagFilterPredicate: ((String) -> Bool) = { _ in return false } | |||
There was a problem hiding this comment.
Both of them should be optional
|
Thanks for this PR @krjackso , that could be really useful. Could you please take a look at the tests? Travis is failing |
|
Okay I made the fixes, which also fixed the build. I also added a test for this functionality |
|
Thanks @krjackso , merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this feature so that hashtags and mentions that were not actionable/valid in my app would not appear that way to my users (e.g. only @mentions for other valid users should appear to be tappable). I did not add url filtering because I could not think of a valid use for that. With the addition of the customize block a change like this should have little impact for those not using it.