Merge pull request #320 from c-bata/skip-table-creation

Use `skip_table_creation` when using Optuna v3 or later
optuna · Dec 26, 2022 · bd99630 · bd99630
2 parents 5abdcbd + ad1fbcd
commit bd99630
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/optuna_dashboard/_app.py b/optuna_dashboard/_app.py
@@ -406,6 +406,8 @@ def get_storage(storage: Union[str, BaseStorage]) -> BaseStorage:
             raise ValueError(
                 "RedisStorage is unsupported from Optuna v3.1 or Optuna Dashboard v0.8.0"
             )
+        elif version.parse(optuna_ver) >= version.Version("v3.0.0"):
+            return RDBStorage(storage, skip_compatibility_check=True, skip_table_creation=True)
         else:
             return RDBStorage(storage, skip_compatibility_check=True)
     return storage

diff --git a/optuna_dashboard/_cli.py b/optuna_dashboard/_cli.py
@@ -12,6 +12,7 @@
 
 from . import __version__
 from ._app import create_app
+from ._app import get_storage
 from ._sql_profiler import register_profiler_view
 
 
@@ -97,11 +98,7 @@ def main() -> None:
     args = parser.parse_args()
 
     storage: BaseStorage
-    if args.storage.startswith("redis"):
-        raise ValueError("RedisStorage is unsupported from Optuna v3.1 or Optuna Dashboard v0.8.0")
-    else:
-        storage = RDBStorage(args.storage, skip_compatibility_check=True)
-
+    storage = get_storage(args.storage)
     app = create_app(storage, debug=DEBUG)
 
     if DEBUG and isinstance(storage, RDBStorage):