Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort trials by param value #222

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

yoshinobc
Copy link
Contributor

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Motivation

Allow displaying a column for each parameter when the search space matches in all trials.

Description of the changes

  • Added processing if union_search_space.length === intersection_search_space.length

TODO

  • Categorical parameter filtering is not yet implemented.

The attached zip file is a zipped version of the db file containing the study and the python file used to create it.
sklearn_simple_all_parameter_intersect.zip

@yoshinobc
Copy link
Contributor Author

Sorry, it looks like the typescript test failed.
How can I test typescript locally? (jest.config.js is in this repository, but I don't really understand how to use jest.)

@c-bata
Copy link
Member

c-bata commented Apr 26, 2022

Sorry, it looks like the typescript test failed. How can I test typescript locally? (jest.config.js is in this repository, but I don't really understand how to use jest.)

You can use $ npm run test as GitHub actions do.
https://github.com/optuna/optuna-dashboard/blob/main/.github/workflows/typescript-tests.yml#L60

@yoshinobc
Copy link
Contributor Author

Thank you for your comment.

In the test script,

  1. getByText has been updated to generate an error when multiple elements are found in getByText.
  2. The update of StudyDetail.tsx has added a new text "value 1" of y param with trial_id=2.

For this reason, it has been changed to retrieve 'number'(0 index) after getting it with getAllByText.

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💯 LGTM!

@c-bata
Copy link
Member

c-bata commented Apr 26, 2022

param-independent.mp4

@c-bata c-bata merged commit 1e3d8b0 into optuna:main Apr 26, 2022
@c-bata c-bata mentioned this pull request Apr 26, 2022
1 task
@c-bata c-bata changed the title add each param columns Add each param columns and make them sortable. Apr 26, 2022
@c-bata c-bata changed the title Add each param columns and make them sortable. Add each param columns and make them sortable Apr 26, 2022
@c-bata c-bata changed the title Add each param columns and make them sortable Sort trials by param value Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants