Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when given -inf or nan values #237

Merged
merged 5 commits into from
May 25, 2022
Merged

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented May 25, 2022

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Follow-up #176

What does this implement/fix? Explain your changes.

  • Accept "-inf" value as trial.values
  • Accept "-inf" and "nan" value as trial.intermediate_values
posinf-neginf-nan.mp4

@c-bata c-bata added the bug Something isn't working label May 25, 2022
@c-bata c-bata merged commit 8d6172b into optuna:main May 25, 2022
@c-bata c-bata deleted the fix-neg-inf branch June 6, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant