Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the project metadata in pyproject.toml instead of setup.cfg #266

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Sep 12, 2022

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

  • Define the project metadata in pyproject.toml instead of setup.cfg.

@c-bata c-bata marked this pull request as ready for review September 12, 2022 11:59
@c-bata
Copy link
Member Author

c-bata commented Sep 12, 2022

I tried to use setuptools_scm to simplify the release operation at 8c80c77.
However, as discussed in pypa/setuptools_scm#190, setuptools_scm's file_finders implicitly bundles SCM files with the source package. That is, .github, python_tests, tools, etc. are bundled with sdist. To exclude these files, I need to list the files to be excluded in MANIFEST.in or implement a fragile monkey patch in setup.py.

Therefore, I decided to avoid using setuptools_scm in this project.

@c-bata c-bata merged commit 6a26cdb into optuna:main Sep 13, 2022
@c-bata c-bata deleted the use-pyproject-toml branch September 13, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant