Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Human-in-the-loop example #455

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented May 10, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Follow-up #428

What does this implement/fix? Explain your changes.

Please merge this PR after Optuna v3.1.0 and Optuna Dashboard v0.10.0 are released.

@c-bata c-bata force-pushed the update-hitl-example branch 3 times, most recently from 7a25584 to 4921bea Compare May 12, 2023 04:03
@c-bata c-bata marked this pull request as ready for review May 23, 2023 09:25
Copy link
Member

@keisuke-umezawa keisuke-umezawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left nits and question. You can merge it anytime.

docs/tutorials/hitl.rst Outdated Show resolved Hide resolved
storage = optuna.storages.RDBStorage(url=url)

# 2. Create Artifact Storage
# 1. Create Artifact Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] Why did we move those line into start_optimization?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To just simplify the code. Thank you for your question.

@c-bata c-bata merged commit 9287158 into optuna:main May 25, 2023
8 checks passed
@c-bata c-bata deleted the update-hitl-example branch May 25, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants