Add history graph use case in e2e tests #514
Merged
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bata
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
LGTM.
However, I'd like to share some concerns. The current approach to write e2e_tests could lead to potential issues as the number of test cases increases. We need to create multiple studies within conftest.py for each test case although this test case only require the first study. So that it could substantially increases the time for running tests.
Moreover, I have a maintainability concern. If each test needs to assert more detailed conditions, it heavily depends on studies, set up in conftest.py. It makes tests complex. Ideally, it would be better to prepare only the minimum necessary studies for each test case.
|
@c-bata |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
What does this implement/fix? Explain your changes.