Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slider to change the marker size #517

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Jul 5, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

marker-size-change

@c-bata
Copy link
Member Author

c-bata commented Jul 5, 2023

@HideakiImamura Could you review this PR?

@HideakiImamura
Copy link
Member

It seemed to me that we could focus on smaller areas. This is because it seems to me that we may want to reduce the size of a dot, but not to make it larger than it currently is.

@c-bata
Copy link
Member Author

c-bata commented Jul 5, 2023

Thanks for your input. I'm thinking of narrowing down the range to 1-10. What do you think?

@HideakiImamura
Copy link
Member

Sounds good. Could you apply the change?

@c-bata
Copy link
Member Author

c-bata commented Jul 6, 2023

Applied. PTAL.

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 1c25ba0 into optuna:main Jul 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants