Add constraints for pareto front #525
Conversation
|
In order to work with optuna v2.1, _CONSTRAINT_KEY, which was imported in _serializer.py, is no longer used and is defined as a constant in the file. |
How long should we support optuna v2.1? |
| @@ -30,6 +30,7 @@ interface TrialResponse { | |||
| system_attrs: Attribute[] | |||
| note: Note | |||
| artifacts: Artifact[] | |||
| constraints: number[] | |||
There was a problem hiding this comment.
[nits] If we want to align with the other fields such as values?, should it be also an optional field?
| @@ -112,6 +112,7 @@ type Trial = { | |||
| }[] | |||
| user_attrs: Attribute[] | |||
| system_attrs: Attribute[] | |||
| constraints: number[] | |||
There was a problem hiding this comment.
I left some minor comments and also request some comments to @c-bata . Overall, almost looks good to me!
|
I have updated constraint value to an optional in response to your comment. |
Thank you for asking. I think we can consider dropping Optuna v2 support from the next release 👍 Then, we need to replace this line with |
|
@hrntsm Currently, if there are not any constraints, the However, I realized that it will introduce a lot of code changes, and there is not so much benefit to change Afterwards, I will merge it. |
This reverts commit 7fbcb19.
|
I understand the intent of your comment. Thank you. |
|
@hrntsm |
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Related #316 , Constraints supported for PareteFront.
What does this implement/fix? Explain your changes.
Since the constraint values are used in other plots, I use optuna's _CONSTRAINT_KEY to serialize the constraint values.
The results, reflecting the constraints, are shown below. A feasible trial has a gray line around the edge, while an infasible trial has a gray marker with no edge line.