Store artifact meta in trial_system_attr
#564
Merged
+159
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alnusjaponica
changed the title
trial_system_attr
keisuke-umezawa
approved these changes
Aug 21, 2023
c-bata
reviewed
Aug 24, 2023
Comment on lines
19
to
62
| def init_storage_with_artifact_meta() -> MagicMock: | ||
| storage = MagicMock() | ||
|
|
||
| get_study_system_attrs = ( | ||
| lambda study_id: { | ||
| "dashboard:artifacts:0:id0": '{"artifact_id": "id0", "filename": "foo.txt"}', | ||
| "dashboard:artifacts:0:id1": '{"artifact_id": "id1", "filename": "bar.txt"}', | ||
| "baz": "baz", | ||
| } | ||
| if study_id == 0 | ||
| else {} | ||
| ) | ||
| storage.get_study_system_attrs.side_effect = get_study_system_attrs | ||
|
|
||
| trial0_system_attrs = { | ||
| "artifacts:id2": '{"artifact_id": "id2", "filename": "baz.txt"}', | ||
| } | ||
| trial1_system_attrs = { | ||
| "artifacts:id3": '{"artifact_id": "id3", "filename": "qux.txt"}', | ||
| } | ||
| get_trial_system_attrs = ( | ||
| lambda trial_id: trial0_system_attrs | ||
| if trial_id == 0 | ||
| else trial1_system_attrs | ||
| if trial_id == 1 | ||
| else {} | ||
| ) | ||
| storage.get_trial_system_attrs.side_effect = get_trial_system_attrs | ||
|
|
||
| get_all_trials = ( | ||
| lambda study_id: [ | ||
| MagicMock( | ||
| _trial_id=0, study=MagicMock(_study_id=study_id), system_attrs=trial0_system_attrs | ||
| ), | ||
| MagicMock( | ||
| _trial_id=1, study=MagicMock(_study_id=study_id), system_attrs=trial1_system_attrs | ||
| ), | ||
| ] | ||
| if study_id == 0 | ||
| else [] | ||
| ) | ||
| storage.get_all_trials.side_effect = get_all_trials | ||
|
|
||
| return storage |
There was a problem hiding this comment.
Overusing MagicMock can decrease the readability and make tests more fragile, increasing maintenance costs. How about creating an actual InMemoryStorage object instead of using a Mock like the test case below?
optuna-dashboard/python_tests/artifact/test_optuna_compatibility.py
Lines 19 to 53 in f125930
Co-authored-by: c-bata <c-bata@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
What does this implement/fix? Explain your changes.