Fix the bug while renaming a study with maximize direction #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bata
reviewed
Aug 25, 2023
There was a problem hiding this comment.
@lucasmrdt Good catch! Thank you for your pull request.
I left one comment. Could you update the PR?
optuna_dashboard/_app.py
Outdated
Comment on lines
147
to
149
| dst_study = optuna.create_study( | ||
| storage=storage, study_name=dst_study_name, directions=summary.directions | ||
| ) |
There was a problem hiding this comment.
You can get directions of the source study from a src_study object. So you don't need to get study_summary object.
Could you apply the following suggestion and remove L142-L145?
Suggested change
| dst_study = optuna.create_study( | |
| storage=storage, study_name=dst_study_name, directions=summary.directions | |
| ) | |
| dst_study = optuna.create_study( | |
| storage=storage, study_name=dst_study_name, directions=src_study.directions | |
| ) |
c-bata
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
none
What does this implement/fix? Explain your changes.
In version 0.12.0, if a study with the maximize direction is renamed, it results in a new study being created with the minimize direction. To address this, I've transferred the original study's directions to the newly created study.