[preferential] Change behavior of best_trials and remove mark_comparison_ready
#596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Followup: Change UI |
Codecov Report
@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 55.68% 55.28% -0.40%
==========================================
Files 34 34
Lines 2094 2100 +6
==========================================
- Hits 1166 1161 -5
- Misses 928 939 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
contramundum53
changed the title
best_trials and remove mark_comparison_ready
c-bata
requested changes
Sep 6, 2023
There was a problem hiding this comment.
@contramundum53 Thank you for your pull request! I left one comment.
contramundum53
commented
Sep 6, 2023
Co-authored-by: c-bata <c-bata@users.noreply.github.com>
…board into active_trials
c-bata
reviewed
Sep 7, 2023
Co-authored-by: c-bata <c-bata@users.noreply.github.com>
Co-authored-by: c-bata <c-bata@users.noreply.github.com>
Co-authored-by: c-bata <c-bata@users.noreply.github.com>
c-bata
approved these changes
Sep 7, 2023
moririn2528
reviewed
Sep 7, 2023
There was a problem hiding this comment.
In 162 line,
isBestTrial={() => true}
This is written because all displayed trials are best. So could you change this one?
There was a problem hiding this comment.
LGTM except for the above nit.
There was a problem hiding this comment.
Thank you for your comment!
I fixed this issue, so I'll merge it myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
What does this implement/fix? Explain your changes.
Change the behavior of
best_trialsto "reported good at least once, not reported bad and not skipped".Remove
mark_comparison_readysince it is not necessary anymore.Depends on #595.