Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for samplers of preferential optimization #623

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

not522
Copy link
Member

@not522 not522 commented Sep 22, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Add unit tests for samplers of preferential optimization.

@c-bata
Copy link
Member

c-bata commented Sep 22, 2023

@contramundum53 Could you review this PR?

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #623 (1c4037f) into main (e40f410) will increase coverage by 6.47%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   56.40%   62.88%   +6.47%     
==========================================
  Files          35       35              
  Lines        2193     2193              
==========================================
+ Hits         1237     1379     +142     
+ Misses        956      814     -142     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53 contramundum53 merged commit 5c7ea74 into optuna:main Sep 26, 2023
12 checks passed
@not522 not522 deleted the test-preferential-samplers branch September 29, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants