-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for _orthants_MVN_Gibbs_sampling
#650
Conversation
This pull request has not seen any recent activity. |
This pull request was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely. |
@not522 Could you resolve the CI failure and file conflict? Or you could simply close this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 67.20% 68.22% +1.02%
==========================================
Files 35 35
Lines 2293 2329 +36
==========================================
+ Hits 1541 1589 +48
+ Misses 752 740 -12 ☔ View full report in Codecov by Sentry. |
Thank you for notification. I have updated to resolve conflict and marked it ready for review. Could you check it? |
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Please merge #649 first.
What does this implement/fix? Explain your changes.
Add test for
_orthants_MVN_Gibbs_sampling
. Since it is difficult to test the algorithm involving random numbers, this test only checks that the function works and the return value's shape.