Ordering trial by value should always de-prioritise undefined values #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #666 +/- ##
==========================================
+ Coverage 62.65% 62.88% +0.23%
==========================================
Files 35 35
Lines 2252 2250 -2
==========================================
+ Hits 1411 1415 +4
+ Misses 841 835 -6 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Could you fix the linter error? When it's fixed, a reviewer will be assigned. |
|
I've suppressed the errors for now, as we don't seem to have any variable pattern exclusions for this rule. Separately, not sure why that hasn't fixed the check. |
|
Could you run ? |
|
@c-bata Could you review this PR? |
keisuke-umezawa
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Fixes #264
What does this implement/fix? Explain your changes.
As we aren't considering the ascending/descending nature of sort, we end up having trials with no value appearing above trials with values in certain cases (see referenced issue). This fix takes this into account.