Add an e2e test to upload a db file in standalone dashboard #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
==========================================
+ Coverage 62.88% 68.22% +5.33%
==========================================
Files 35 35
Lines 2250 2329 +79
==========================================
+ Hits 1415 1589 +174
+ Misses 835 740 -95 ☔ View full report in Codecov by Sentry. |
keisuke-umezawa
changed the title
keisuke-umezawa
force-pushed
the
feature/add-db-import-test
branch
from
ecdf860
to
04215cd
Compare
c-bata
reviewed
Nov 27, 2023
| page: Page, | ||
| server_url: str, | ||
| ) -> None: | ||
| current_dir = os.getcwd() |
There was a problem hiding this comment.
How about using tempfile.TemporaryDirectory to avoid the SQLite3 file from being left when running the E2E tests on our local machines?
| assert element is not None | ||
| title = element.text_content() | ||
| assert title is not None | ||
| assert title == "Optuna Dashboard" |
There was a problem hiding this comment.
How about checking the number of <Card> components that shows the study names?
|
Let me unassign me from the reviewer. @keisuke-umezawa Please merge this PR after you updated. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
Add an e2e test to upload db file in standalone dashboard