Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio artifact component #697

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

contramundum53
Copy link
Member

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

The layout of audio artifact component was broken so I fixed it.

image

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #697 (fba9cf1) into main (462f609) will not change coverage.
Report is 11 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   62.88%   62.88%           
=======================================
  Files          35       35           
  Lines        2250     2250           
=======================================
  Hits         1415     1415           
  Misses        835      835           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. I've noticed that there is a similar issue when uploading .zip files, but it should be handled in the following PR. LGTM!

Screenshot 2023-11-13 19 45 34

@c-bata c-bata added the bug Something isn't working label Nov 13, 2023
@c-bata c-bata merged commit 4e6d748 into optuna:main Nov 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants