Fix sort in rank plot #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
=======================================
Coverage 65.80% 65.80%
=======================================
Files 35 35
Lines 2293 2293
=======================================
Hits 1509 1509
Misses 784 784 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -274,7 +274,7 @@ const getColors = (values: number[]): number[] => { | |||
| } | |||
|
|
|||
| const getOrderWithSameOrderAveraging = (values: number[]): number[] => { | |||
| const sortedValues = values.slice().sort() | |||
There was a problem hiding this comment.
This causes a bug when there are inf values.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
This feature has been introduced by #656.
What does this implement/fix? Explain your changes.
The sorting in the rank plot is not correct because the values are sorted as strings. This PR will fix the bug by specifying a compare function.