Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix journal storage handling in windows #742

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

hrntsm
Copy link
Collaborator

@hrntsm hrntsm commented Dec 30, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

optuna/optuna#4308

What does this implement/fix? Explain your changes.

In windows environment, if lock_obj is not specified explicitly, the same error as reference will occur when handling JournalStorage, so os is determined and lock_obj is included in the argument.

This is probably why the human-in-the-loop optimization does not work because the change to the journal storage cannot be performed.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (1203501) 68.22% compared to head (5d3989a) 68.20%.
Report is 196 commits behind head on main.

❗ Current head 5d3989a differs from pull request most recent head 02999c7. Consider uploading reports for the commit 02999c7 to get more accurate results

Files Patch % Lines
optuna_dashboard/artifact/_backend.py 31.42% 24 Missing ⚠️
optuna_dashboard/_app.py 94.59% 2 Missing ⚠️
optuna_dashboard/_storage_url.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   68.22%   68.20%   -0.02%     
==========================================
  Files          35       35              
  Lines        2329     2334       +5     
==========================================
+ Hits         1589     1592       +3     
- Misses        740      742       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-bata c-bata merged commit 0da1b9d into optuna:main Jan 9, 2024
1 check passed
@hrntsm hrntsm deleted the fix-journal-storage-handling-in-windonws branch January 9, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants