Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Dashboard's ArtifactNotFound exception to Optuna's one #753

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Jan 16, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Follow-up #540 and #752.

What does this implement/fix? Explain your changes.

Convert Dashboard's ArtifactNotFound exception to Optuna's one

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (99a54cb) 68.81% compared to head (fd4ef3d) 69.48%.
Report is 20 commits behind head on main.

Files Patch % Lines
optuna_dashboard/artifact/_backend_to_store.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   68.81%   69.48%   +0.67%     
==========================================
  Files          35       35              
  Lines        2344     2353       +9     
==========================================
+ Hits         1613     1635      +22     
+ Misses        731      718      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata merged commit 7aa7bf9 into optuna:main Jan 16, 2024
12 of 13 checks passed
@c-bata c-bata deleted the dashboard-artifact-exception branch January 16, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant